[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    [patch] option -k of ifplugd did not work
From:       "Matthias Loy" <matthias.loy () hbm ! com>
Date:       2012-12-14 21:39:11
Message-ID: 50CB9C7F.1050808 () hbm ! com
[Download RAW message or body]

Hello,

today I reconized that ifplugd -k does stop the running ifplugd without 
calling ifdown. Sending SIGTERM to the ifplugd did the job, ifdown was 
called before ifplugd stopped.
The solution is simple: ifplugd -k sent the wrong signal. the clean up 
stage was simply omitted!

Attached is the small patch solving the problem.

By the way. A few weeks ago I send another patch concerning ifdown for 
interfaces using a mapped configuration. Until now I haven't got any 
reaction from anybody. Is this not the correct way to have patches 
reviewed or put into the busybox code? Is there anything wrong in the 
way I provide the patches?

Regards,
Matthias Loy

Hottinger Baldwin Messtechnik GmbH, Im Tiefen See 45, 64293 Darmstadt, Germany | \
www.hbm.com 

Registered as GmbH (German limited liability corporation) in the commercial register \
at the local court of Darmstadt, HRB 1147   Company domiciled in Darmstadt | CEO: \
Andreas Huellhorst | Chairman of the board: James Charles Webster

Als Gesellschaft mit beschraenkter Haftung eingetragen im Handelsregister des \
Amtsgerichts Darmstadt unter HRB 1147  Sitz der Gesellschaft: Darmstadt | \
Geschaeftsfuehrung: Andreas Huellhorst | Aufsichtsratsvorsitzender: James Charles \
Webster

The information in this email is confidential. It is intended solely for the \
addressee. If you are not the intended recipient, please let me know and delete this \
email.

Die in dieser E-Mail enthaltene Information ist vertraulich und lediglich für den \
Empfaenger bestimmt. Sollten Sie nicht der eigentliche Empfaenger sein, informieren \
Sie mich bitte kurz und loeschen diese E-Mail.


["0001-ifplugd-k-should-send-SIGTERM-in-order-to-clean-up-c.patch" (text/x-patch)]

From 2ddc9f016188159871d2526d018690b6b10ab7fb Mon Sep 17 00:00:00 2001
From: Matthias Loy <matthias.loy@hbm.com>
Date: Fri, 14 Dec 2012 22:18:28 +0100
Subject: [PATCH] ifplugd -k should send SIGTERM in order to clean up (call
 ifdown) propperly

---
 networking/ifplugd.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/networking/ifplugd.c b/networking/ifplugd.c
index 88bf448..c5d43a8 100644
--- a/networking/ifplugd.c
+++ b/networking/ifplugd.c
@@ -556,7 +556,7 @@ int ifplugd_main(int argc UNUSED_PARAM, char **argv)
 
 	if (opts & FLAG_KILL) {
 		if (pid_from_pidfile > 0)
-			kill(pid_from_pidfile, SIGQUIT);
+			kill(pid_from_pidfile, SIGTERM);
 		return EXIT_SUCCESS;
 	}
 
-- 
1.7.10.4



_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

[prev in list] [next in list] [prev in thread] [next in thread]