[prev in list] [next in list] [prev in thread] [next in thread]
List: busybox
Subject: Re: [PATCH 17/19] insmod: implement -q flag
From: Denys Vlasenko <vda.linux () googlemail ! com>
Date: 2012-09-30 7:13:33
Message-ID: CAK1hOcMaAQ7RxAimmnm0RZThiEQa1W_wAzGEYzZZ9mMiO7ydzg () mail ! gmail ! com
[Download RAW message or body]
On Tue, Sep 25, 2012 at 2:06 PM, Florian Fainelli <florian@alphacore.org> wrote:
> From: Jo-Philipp Wich <jow@openwrt.org>
>
> And suppress errors when this flag is set.
>
> Signed-off-by: Jo-Philipp Wich <jow@openwrt.org>
> ---
> modutils/insmod.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/modutils/insmod.c b/modutils/insmod.c
> index 887d9f2..22bac1f 100644
> --- a/modutils/insmod.c
> +++ b/modutils/insmod.c
> @@ -39,7 +39,7 @@ int insmod_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE;
> int insmod_main(int argc UNUSED_PARAM, char **argv)
> {
> char *filename;
> - int rc;
> + int rc, opt;
>
> /* Compat note:
> * 2.6 style insmod has no options and required filename
> @@ -49,17 +49,15 @@ int insmod_main(int argc UNUSED_PARAM, char **argv)
> * or in $MODPATH.
> */
>
> - IF_FEATURE_2_4_MODULES(
> - getopt32(argv, INSMOD_OPTS INSMOD_ARGS);
> - argv += optind - 1;
> - );
> + opt = getopt32(argv, INSMOD_OPTS, NULL, NULL);
> + argv += optind - 1;
This makes 2.6 insmod support options.
Which introduces incompatibility with standard
2.6 insmod, which does not accept any options.
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic