[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH 10/19] udhcpc: do not call deconfig when entering the renew phase
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2012-09-29 14:52:22
Message-ID: 201209291652.22259.vda.linux () googlemail ! com
[Download RAW message or body]

On Tuesday 25 September 2012 14:06, Florian Fainelli wrote:
> From: Felix Fietkau <nbd@openwrt.org>
> 
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> ---
>  networking/udhcp/dhcpc.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/networking/udhcp/dhcpc.c b/networking/udhcp/dhcpc.c
> index 7d38d9d..ecbdb8e 100644
> --- a/networking/udhcp/dhcpc.c
> +++ b/networking/udhcp/dhcpc.c
> @@ -1078,7 +1078,6 @@ static void perform_renew(void)
>  		state = RENEW_REQUESTED;
>  		break;
>  	case RENEW_REQUESTED: /* impatient are we? fine, square 1 */
> -		udhcp_run_script(NULL, "deconfig");
>  	case REQUESTING:
>  	case RELEASED:
>  		change_listen_mode(LISTEN_RAW);

The patch is not doing what description says.

We reach this line if user sends _two_ SIGUSR1 signals to us.

Which we currently treat as "forget everything, assume
no lease exists, and stat from INIT_SELECTING state".

In this case, "deconfig" makes sense.

-- 
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]