[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH 11/19] gen_build_files: use bash to avoid printf argument list issues.
From:       Florian Fainelli <florian () alphacore ! org>
Date:       2012-09-27 8:17:03
Message-ID: 1884354.UutqrEWsr7 () flexo
[Download RAW message or body]

On Tuesday 25 September 2012 18:40:22 Rich Felker wrote:
> On Tue, Sep 25, 2012 at 02:06:10PM +0200, Florian Fainelli wrote:
> > From: Felix Fietkau <nbd@openwrt.org>
> > 
> > Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> > ---
> >  scripts/gen_build_files.sh |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/scripts/gen_build_files.sh b/scripts/gen_build_files.sh
> > index 0989b2f..60edf07 100755
> > --- a/scripts/gen_build_files.sh
> > +++ b/scripts/gen_build_files.sh
> > @@ -1,4 +1,4 @@
> > -#!/bin/sh
> > +#!/usr/bin/env bash
> 
> If there's a bug in this script that's causing problems on other
> shells, it should be fixed. Breaking busybox so it can't be
> self-hosting is a step backwards.

This patch is actually quite old, I will double check whether this is still 
necessary, I guess not anymore.
--
Florian
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]