[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: unzip applet not working ?
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2012-06-26 14:18:18
Message-ID: CAK1hOcMgNeZcc+yRsuOAMbEq4ZwmqLjDmRa6P=XwDawnC2gyJA () mail ! gmail ! com
[Download RAW message or body]

On Sat, Jun 23, 2012 at 9:52 PM, Doug Clapp <doug.clapp@triad.rr.com> wrote:
>> commit c5b01016e622f01dfa9c8c542c0968fe37d4a5f2
>> Author: Denys Vlasenko <vda.linux@googlemail.com>
>> Date: =A0 Fri Jun 15 16:43:26 2012 +0200
>>
>> =A0 =A0 unzip: make options parsing more robust on getopt w/o gnu extens=
ions
>>
>> =A0 =A0 Also, code shrank:
>>
>> =A0 =A0 function =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 old =A0 =A0 new
>> delta
>> =A0 =A0 static.extn =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 15 =A0 =A0 =A010
>> =A0-5
>> =A0 =A0 packed_usage =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
 =A0 =A0 =A0 =A0 =A0 =A0 29231 =A0 29217
>> -14
>> =A0 =A0 unzip_main =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A02388 =A0 =A02291
>> -97
>>
>> ------------------------------------------------------------------------=
------
>> =A0 =A0 (add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-116)
>> Total: -116 bytes
>>
>>
>> After it, only -x will break.
>> _______________________________________________
>> busybox mailing list
>> busybox@busybox.net
>> http://lists.busybox.net/mailman/listinfo/busybox
>>
> Attached is new source file unzip.c. Following John Spencer's email on Ju=
ne
> 14, I decided to tackle his suggestion of parsing the command line without
> getopt. I think I have succeeded in that. One minor issue is -qq, which is
> treated the same as -q. If you want the -qq behavior, use -q -q. If I did=
 it
> right, the output from make bloatcheck is:
>
> function =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 =A0 =A0 old =A0 =A0 new =A0 delta
> unzip_main =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 =A0 =A01564 =A0 =A01925 =A0 =A0+361
> .rodata =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 =A0 =A0 2389 =A0 =A02384 =A0 =A0 =A0-5
> -------------------------------------------------------------------------=
-----
> (add/remove: 0/0 grow/shrink: 1/1 up/down: 361/-5) =A0 =A0 =A0 =A0 =A0 =
=A0Total: 356
> bytes
> =A0 text =A0 =A0data =A0 =A0 bss =A0 =A0 dec =A0 =A0 hex filename
> =A024894 =A0 =A0 430 =A0 =A0 =A044 =A0 25368 =A0 =A06318 busybox_old
> =A025274 =A0 =A0 434 =A0 =A0 =A044 =A0 25752 =A0 =A06498 busybox_unstripp=
ed
>
> In my testing both -d and -x appear to function correctly.
>
> I have made documentation suggestions before, but this is my first code
> contribution.

Please send a diff.
Please follow code style of the surrounding code.
Please use tabs consistently.

-- =

vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]