[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH 1/6] android: some sensible defconfig changes
From:       Tias <tias () ulyssis ! org>
Date:       2012-05-31 21:26:51
Message-ID: 4FC7E21B.4020109 () ulyssis ! org
[Download RAW message or body]

On 05/29/2012 01:35 AM, Rich Felker wrote:
> On Tue, May 29, 2012 at 01:25:40AM +0200, ralda@gmx.de wrote:
>>> - ls --color (default)
>>> +CONFIG_FEATURE_LS_COLOR_IS_DEFAULT=y
>>
>> This is a bad idea. LS_COLOR_IS_DEFAULT breaks the usage of ls in many
>> shell scripts ... or at least did this in older versions (don't know if
>> newer versions have any workaround for this).
>
> The proper use of color-ls-by-default is with a shell alias; IMO this
> option should be removed from busybox since it's so broken. And yes,
> the breakage is still there, or at least explicit --color affects
> output even if it's not a terminal.

Interesting.

I actually copied that setting over from a 'make defconfig' run, 
assuming it is a sensible default.
So I guess at the least it should not be set when run 'make defconfig'?


Kind regards,
Tias
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]