[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] tar: support the common file extensions .tlzma and .txz
From:       Lauri Kasanen <curaga () operamail ! com>
Date:       2012-02-29 20:03:30
Message-ID: 1330545810.32630.140661043069489 () webmail ! messagingengine ! com
[Download RAW message or body]

> > Hi Denys
> >
> > The attached patch adds support for .txz and .tlzma tar archives. For
> > .txz the proper way would be to add the magic detection
> 
> The autodetection should already work, see archival/tar.c:

Using git master:

$ ./busybox tar tvf /tmp/test.txz
tar: invalid tar magic

Renaming the file to .tar.xz lets bb tar read it.

> I am not convinced .txz and .tlzma extensions are common.
> (In my opinion, existence of .tgz extension was a mistake).

They exist, and GNU tar handles them, so I think bb tar shouldn't puke
when it sees one. Busybox does handle .tgz and .tbz2, because they have
the magic detection already written (xz magic is marked todo in
archival/libarchive/get_header_tar.c).

- Lauri

-- 
http://www.fastmail.fm - Does exactly what it says on the tin

_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]