[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH 2/2] modprobe-small: allow blacklist for compatibility
From:       Felipe Contreras <felipe.contreras () gmail ! com>
Date:       2012-01-31 14:48:54
Message-ID: CAMP44s1zO1_O1Vz0PfbUBDjn+qg0jPX3DA=am1uAY06xMThm5A () mail ! gmail ! com
[Download RAW message or body]

On Tue, Jan 31, 2012 at 3:46 PM, Denys Vlasenko
<vda.linux@googlemail.com> wrote:
> On Fri, Jan 20, 2012 at 12:07 AM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>> ---
>>  modutils/modprobe-small.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/modutils/modprobe-small.c b/modutils/modprobe-small.c
>> index f5b283b..2b1b6c5 100644
>> --- a/modutils/modprobe-small.c
>> +++ b/modutils/modprobe-small.c
>> @@ -805,7 +805,7 @@ int modprobe_main(int argc UNUSED_PARAM, char **argv)
>>        opt_complementary = "-1";
>>        /* only -q (quiet) and -r (rmmod),
>>         * the rest are accepted and ignored (compat) */
>> -       getopt32(argv, "qrfsvw");
>> +       getopt32(argv, "bqrfsvw");
>>        argv += optind;
>
> This is wrong. Comment just before this code even tried to prevent
> this kind of bug: it says that -q and -r are used.
>
> Check OPT_q and OPT_r constants in this file.

OK. I didn't test this change, just seemed straight-forward.

Cheers.

-- 
Felipe Contreras
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]