[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: acpid hangs with full cpu usage when removing USB input devices
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2012-01-10 17:06:29
Message-ID: CAK1hOcOywKeUfcHPjMQkUJDPhnir7SKZeugjEh_T-hEJ7BobaA () mail ! gmail ! com
[Download RAW message or body]

On Tue, Jan 10, 2012 at 8:04 AM, Natanael Copa <natanael.copa@gmail.com> wrote:
> On Mon, Jan 9, 2012 at 5:13 PM, Denys Vlasenko <vda.linux@googlemail.com> wrote:
>> On Mon, Jan 9, 2012 at 4:58 PM, Natanael Copa <natanael.copa@gmail.com> wrote:
> ...
>>> fork/exec'ing itself again would solve that.
>>
>> Well, not really, because we do not know WHEN to re-exec.
>> We don't know when new devices appear.
>
> ofcourse...
>
>>> Do you have other applets
>>> that re-start themselves? I could send a new patch - including a
>>> comment with a reference for the ignore fd == -1 thingy. Or should we
>>> just exit the acpid and let a hook script restart it?
>>
>> I think a good solution is when hotplug machinery does something like
>> "sv t /var/service/acpid" whenever a new input device appears.
>
> That should work. I need to figure out how to do so with udev. mdev
> should be pretty straightforward.
>
> Thanks!
>
> So the original patch was good? You want me resend it with comment?

No need to resend, I already applied it together with other fixes
(a few missing free's, wrong handling of -d, and poll
wasn't safe wrt EINTR):

http://git.busybox.net/busybox/commit/?id=982fdaf4b2f335506e570a06d5eab09068da3f61

Thanks!
-- 
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]