[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] httpd: don't drop QUERY_STRING when /cgi-bin/index.cgi is
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2011-12-16 11:19:09
Message-ID: CAK1hOcNqc6tAJWZgP6qasbAHvRtDGRODu=HpGeXKYAyk9icoDQ () mail ! gmail ! com
[Download RAW message or body]

On Fri, Dec 16, 2011 at 10:13 AM, Peter Korsgaard <jacmet@sunsite.dk> wrote:
>>>>>> "Denys" == Denys Vlasenko <vda.linux@googlemail.com> writes:
>
>  >>  Denys> Let's just use xstrcpy().
>  >>
>  >> I don't see any xstrcpy in busybox. Did you perhaps mean xstrdup or
>  >> strdupa?
>
>  Denys> Oops. I meant xstrdup.
>
> But then we would have to take care to not leak memory, which is a bit
> complicated because of send_file_and_exit() / send_cgi_and_exit().

We implicitly free all memory on exit.

> What is the reason you don't like alloca / strdupa?

I don't know. I guess it will be fewer bytes of code.
-- 
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]