[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH v2 1/4] dhcp6c: decode_base64()
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2011-10-28 12:05:02
Message-ID: CAK1hOcMrX_-DCv68AHZQwpe4AW0HFLXO_iV7SvD4B+z1ZqUnkg () mail ! gmail ! com
[Download RAW message or body]

On Sun, Oct 23, 2011 at 1:12 PM, Leonid Lisovskiy <lly.dev@gmail.com> wrote:
> On Tue, Oct 18, 2011 at 2:19 PM, Denys Vlasenko
> <vda.linux@googlemail.com> wrote:
>> After you created decode_base64 which operates on string,
>> rewrite read_base64 to use it (say, by loop "read up to N*4 bytes,
>> decode them, repeat if no decode error, no EOF and no end char
>> encountered").
>>
>> This may need some tweaks: decode_base64 should be taught
>> how to decode partial (incomplete) base64 string.
>
> I prepare suggested variant, please take a look on patch attached, but
> it has worse code size (+28 bytes) than copy-n-paste :((
> Will try to optimize it, but currently have no good ideas...

It also fails to decode data which decodes to NUL bytes.

I fixed it and and committed to git. Thanks.
-- 
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]