[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH RESEND] cttyhack: remove the trailing newline when reading
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2011-08-16 21:31:19
Message-ID: 201108162331.19754.vda.linux () googlemail ! com
[Download RAW message or body]

On Sunday 14 August 2011 22:55, Kevin Cernekee wrote:
> The current version of cttyhack does not properly truncate the newline
> at the end of the string read from /sys/class/tty/console/active .
> Prior discussion here:
> 
> http://lists.busybox.net/pipermail/busybox/2011-July/thread.html#76139
> http://lists.busybox.net/pipermail/busybox/2011-July/076276.html
> 
> I have verified that the problem impacts v1.19.0.
> 
> Bloat-o-meter:
> 
> function                                             old     new   delta
> ------------------------------------------------------------------------------
> (add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0)                 Total: 0 bytes
>    text    data     bss     dec     hex filename
>  478349    1338    4441  484128   76320 busybox_old
>  478349    1338    4441  484128   76320 busybox_unstripped
> 
> I am also attaching a (new) spelling/whitespace fix, for the same file.

Applied, thanks!

-- 
vda
 
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]