[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [BUG] Linux 3.0 commit 3627924acf70a broke include/mtd/ubi_user.h.
From:       Rob Landley <rob () landley ! net>
Date:       2011-08-14 19:16:29
Message-ID: 4E481F0D.3090404 () landley ! net
[Download RAW message or body]

On 08/14/2011 01:03 PM, Stefan Richter wrote:
> On Aug 14 Rob Landley wrote:
> > "make headers_install" copies include/mtd/ubi_user.h to userspace, where
> > things like busybox link against it.  With 3.0, building defconfig
> > busybox gets this error:
> > 
> > In file included from miscutils/ubi_tools.c:63:
> > /home/landley/aboriginal/aboriginal/build/simple-cross-compiler-i686/bin/../include/mtd/ubi-user.h:329:
> >                 
> > error: conflicting types for '__packed'
> > /home/landley/aboriginal/aboriginal/build/simple-cross-compiler-i686/bin/../include/mtd/ubi-user.h:313:
> >                 
> > error: previous declaration of '__packed' was here
> > 
> > This is due to the Linux 3.0 commit in the title:
> > 
> > UBI: use __packed instead of __attribute__((packed))
> > 
> > This relies on __packed being defined in:
> > 
> > include/linux/compiler-gcc.h:
> > #define __packed			__attribute__((packed))
> > 
> > Which is not exported to userspace.
> > 
> > I.E. this "cleanup" broke the ability for userspace to use this header,
> > even though the header is exported to userspace by headers_install.
> 
> As far as I can tell, the __packed or __attribute__((packed))
> qualifications are superfluous in include/mtd/ubi-user.h anyway.

And Adrian Hunter <adrian.hunter@nokia.com> (the other listed UBI
maintainer) also bounces.  Did the developer exodus after Nokia decided
to cozy up to The Black Widow take 'em both out?

Rob
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox


[prev in list] [next in list] [prev in thread] [next in thread]