[prev in list] [next in list] [prev in thread] [next in thread]
List: busybox
Subject: Re: [PATCH] implement find -ipath
From: Denys Vlasenko <vda.linux () googlemail ! com>
Date: 2011-05-22 22:42:08
Message-ID: 201105230042.08472.vda.linux () googlemail ! com
[Download RAW message or body]
On Sunday 22 May 2011 20:30, Rich Felker wrote:
> On Sun, May 22, 2011 at 04:35:11AM +0200, Denys Vlasenko wrote:
> > > Also, note that it's nearly impossible to implement case folding
> > > fnmatch without just implementing fnmatch in terms of regex, due to
> > > the complexity of Unicode case folding, so we have very good reason
> > > for not supporting this nonstandard extension in musl...
> >
> > You don't have to implement Unicode case folding. ASCII will be enough
> > for 99.9% of users.
>
> This is a potential solution, but I'm unsure if "Worse is Better"...
Something working most of the time is better than compile failures.
> Anyway I noticed I'd alread added the FNM_CASEFOLD definition to musl
> (as a no-op) to work around Busybox's pre-existing dependency on it.
> So this patch does not break anything that wasn't already broken.
> Still it might be nice to put #ifndef FNM_CASEFOLD / #define
> FNM_CASEFOLD 0 somewhere in the file.
Done.
--
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic