[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: all these warnings...
From:       Harald Becker <ralda () gmx ! de>
Date:       2011-04-30 20:49:52
Message-ID: 4DBC75F0.4020007 () gmx ! de
[Download RAW message or body]

 Hallo Denys!

>                         /* print help */
>                         if (line[1] == '\n') {
>                                 help = nohelp_text;
>                                 if (menu->sym->help)
>                                         help = menu->sym->help;
>                                 printf("\n%s\n", menu->sym->help);
>                                 def = NULL;
>                                 break;
> Above, variable "help" is not used and can be deleted.

Shouldn't this be ... ?

printf( "\n%s\n", help );

or may be better ... ?

printf("\n%s\n", menu->sym->help ? menu->sym->help : nohelp_text );

--
Harald

_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]