[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCHv3] HISTFILESIZE environment variable support in ash and
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2011-03-31 11:20:38
Message-ID: AANLkTi=M0qWAX28HN6CC-9ZWJkV6YDd9jzCD5tVSNrOh () mail ! gmail ! com
[Download RAW message or body]

On Thu, Mar 31, 2011 at 9:21 AM, Alexey Fomenko
<ext-alexey.fomenko@nokia.com> wrote:
> On Sun, 2011-03-27 at 02:05 +0100, ext Denys Vlasenko wrote:
>> I don't see potential "char *history[100000];" as a good thing.
> Decreased to 999
>>
>> In general, interrelation between ash and lineedit you are introducing
>> is wrong. Can you simply add a new member, unsigned hist_max_size,
>> to line_input_t structure, and fill it in ash from $MAXHISTSIZE,
>> instead of using lookupvar_histfilesize()?
> Yep, this looks better indeed.
>>
>> Please don't include debian-specific parts in the patch,
>> they cause errors on apply.
> Ok, sorry.
>> Patch still contains trailing whitespace.
> Fixed in new version (in attachment)

It is still not looking good.
It seems it can be fixed faster if I just do it myself.

Applied in this form:

http://git.busybox.net/busybox/commit/?id=2c4de5b045a79db73052d5b865474a00c9a87e99

-- 
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]