[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH v3] mount: mount--move with mtab support fix
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2011-02-28 4:09:20
Message-ID: 201102280509.20125.vda.linux () googlemail ! com
[Download RAW message or body]

On Tuesday 22 February 2011 16:07, Roman Borisov wrote:
> added new update_mtab_entry() function to update /etc/mtab when new mounted
> entry is created by mount--move. In such case update_mtab_entry() is used in
> mount.c/mount_it_now() function instead of addmntent().

cc1: warnings being treated as errors
util-linux/mount.c:288: error: no previous prototype for 'update_mtab_entry_on_move'

Indentation is broken.

+       if (ENABLE_FEATURE_CLEAN_UP) {
+               for (i = 0; i < count; i++) {
+                       free(entries[i].mnt_fsname);
+                       free(entries[i].mnt_dir);
+                       free(entries[i].mnt_type);
+                       free(entries[i].mnt_opts);
+               } // <---- FORGOT TO free(entries);
+       }

Applied to git after fixing these things. Thanks.

In a bigger picture, I agree with Rob: Linux should
strive to make /proc/mounts usable in all cases,
and make /etc/mtab obsolete.

-- 
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]