[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] mount: nfsmount: ignore unknown mount options when
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2011-02-26 18:03:04
Message-ID: 201102261903.04993.vda.linux () googlemail ! com
[Download RAW message or body]

On Monday 21 February 2011 17:52, Peter Korsgaard wrote:
> Don't fail on unknown nfs mount options. The kernel automatically
> adds a few mount options that we don't currently handle, like:
> 
> 	sec=null|sys|krb5..
> 	mountaddr=<ip>
> 	mountproto=tcp|udp
> 	local_lock=none|all|flock|posix
> 
> Which causes a simple mount -o remount,rw <mountpoint> to fail.
> 
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
> ---
>  util-linux/mount.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/util-linux/mount.c b/util-linux/mount.c
> index 0f213bb..1949c12 100644
> --- a/util-linux/mount.c
> +++ b/util-linux/mount.c
> @@ -1129,6 +1129,9 @@ static NOINLINE int nfsmount(struct mntent *mp, long vfsflags, char *filteropts)
>  				continue;
>  			case 20: // "addr" - ignore
>  				continue;
> +			case -1: // unknown
> +				if (vfsflags & MS_REMOUNT)
> +					continue;
>  			}
>  
>  			val = xatoi_positive(opteq);


Applied, thanks!
-- 
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]