[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] Fix cpu detection in iostat applet for ARM
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2010-08-16 0:50:20
Message-ID: 201008160250.20843.vda.linux () googlemail ! com
[Download RAW message or body]

On Thursday 12 August 2010 15:00, Gustavo Zacarias wrote:
> 
> The new iostat applet tries to count CPUs via /proc/cpuinfo checking for
> "Processor\t:".
> Some architectures like ARM use "processor\t:".

> We should really be using something like get_cpu_nr() from the mpstat
> applet that parses /proc/stat instead since SPARC uses yet another
> convention that won't work with this either.

Yep. That's what I did instead of applying the patch.
-- 
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]