[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] httpd: make Accept-Encoding parsing more robust
From:       Peter Korsgaard <jacmet () sunsite ! dk>
Date:       2010-07-30 5:16:47
Message-ID: 87y6ctlfb4.fsf () macbook ! be ! 48ers ! dk
[Download RAW message or body]

>>>>> "Denys" == Denys Vlasenko <vda.linux@googlemail.com> writes:

Hi,

 >> Thanks. Why did you change my strcasestr() to a strstr()? While I
 >> haven't seen any browsers sending Accept-Encoding: with funky
 >> up/lowercasing, I don't see anything explicit in the spec to disallow
 >> it.

 Denys> Perhaps as speed optimization... I can revert it back if you
 Denys> think it's that important.

With all the strcasecmp() going on for the other headers, I don't think
this is going to change too much - But it's your call.

-- 
Bye, Peter Korsgaard
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic