[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH 5/7] cttyhack: serial console detection is Linux-specific
From:       Jeremie Koenig <jk () jk ! fr ! eu ! org>
Date:       2010-07-30 3:58:51
Message-ID: 20100730035850.GA2691 () arabica
[Download RAW message or body]

On Fri, Jul 30, 2010 at 02:44:47AM +0200, Denys Vlasenko wrote:
> On Thursday 29 July 2010 04:29, Jeremie Koenig wrote:
> > ---
> >  shell/cttyhack.c |   11 ++++++++---
> >  1 files changed, 8 insertions(+), 3 deletions(-)
(...)
> Looks like after this cttyhack will build on !Linux, yes,
> but will be basically useless: both #ifdefs will be skipped,
> and thus it will never detect tty's type.
> 
> Does it make sense to create such formally working, but useless
> applets? (Maybe yes, in the name of script compatibility...)
> 
> What do you think?

I think script compatibility can be a good reason, this being said
debian-installer does not use cttyhack.

Maybe we could add a #warning when no detection method is compiled?
This way cttyhack would still be available on non-Linux, and hopefully
the warning would incite whoever uses it to add code for their own
system.

I'll prepare a new patch and let you judge whether it is worth its
weight of preprocessor cruft.

-- 
Jérémie Koenig <jk@jk.fr.eu.org>
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

[prev in list] [next in list] [prev in thread] [next in thread]