[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] Improve unzip's handling of stream ZIP files
From:       Dan Fandrich <dan () coneharvesters ! com>
Date:       2010-06-18 14:32:39
Message-ID: 20100618143239.GB30260 () coneharvesters ! com
[Download RAW message or body]

On Fri, Jun 18, 2010 at 01:33:00PM +0200, Denys Vlasenko wrote:
> This free() is surely not needed:
> 
> +       free(buf);
>         bb_error_msg_and_die("can't find file table");

I didn't bother seeing if unzip was a NOFORK applet or not, but I added
it as a defense against leaks in case it was or could be converted to be
in the future.

>>> Dan
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]