[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [patch] Makefile
From:       Cristian Ionescu-Idbohrn <cristian.ionescu-idbohrn () axis ! com>
Date:       2010-05-24 16:37:23
Message-ID: 1005241835210.7716 () somehost
[Download RAW message or body]

On Sun, 23 May 2010, Denys Vlasenko wrote:

> On Sunday 23 May 2010 20:44, Cristian Ionescu-Idbohrn wrote:
> > On Sun, 23 May 2010, Denys Vlasenko wrote:
> >
> > > On Sunday 23 May 2010 10:25, Cristian Ionescu-Idbohrn wrote:
> > >
> > > > diff --git a/Makefile b/Makefile
> > > > index 14f5cd1..c231092 100644
> > > > --- a/Makefile
> > > > +++ b/Makefile
> > > > @@ -1001,8 +1001,8 @@ $(mrproper-dirs):
> > > >  mrproper: clean archmrproper $(mrproper-dirs)
> > > >  	$(call cmd,rmdirs)
> > > >  	$(call cmd,rmfiles)
> > > > -	@find -name Config.src | sed 's/.src$/.in/' | xargs -r rm -f
> > > > -	@find -name Kbuild.src | sed 's/.src$//' | xargs -r rm -f
> > > > +	@find -name Config.src | sed 's/.src$$/.in/' | xargs -r rm -f
> > > > +	@find -name Kbuild.src | sed 's/.src$$//' | xargs -r rm -f
> > >
> > > Applied, thanks!
> >
> > Great.  But isn't that so that what you want to match is a '.' character,
> > and not any character, in which case:
> >
> > 	sed 's/\.src$$/.in/'
> > 	       ^
> > 	       is the correct way to do it?
>
> We already know that these files end with .src - "find" ensures that.

Sure.  It's enough.  But not correct, IMO.


Cheers,

-- 
Cristian
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]