[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] fuser: convert generic linked list implementation to the
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2010-05-22 18:46:15
Message-ID: 201005222046.15879.vda.linux () googlemail ! com
[Download RAW message or body]

On Thursday 20 May 2010 15:34, Maksym Kryzhanovskyy wrote:
> Hi Denis,
> 
> the patch converts fuser generic linked list implementation to the 'single instantion'.
> It also change llist 'add' operation to 'append', because the previous works as a
> stack's push and reversing output e.g.:
> 
> $ fuser /bin/bash
> /bin/bash:            1978e  3619e  3705e 20476e
> $ ./busybox fuser /bin/bash
> 20476 3705 3619 1978 
> 
> function                                             old     new   delta
> fuser_main                                           663     947    +284
> search_dev_inode                                      63      73     +10
> get_pid_list                                           -       6      +6
> get_ino_list                                           -       6      +6
> static.l                                               -       4      +4
> add_pid                                               38      39      +1
> add_inode                                             84      85      +1
> scan_dir_links                                       102      76     -26
> scan_link                                             78      46     -32
> file_to_dev_inode                                     64       -     -64
> scan_proc_net                                        310       -    -310
> ------------------------------------------------------------------------------
> (add/remove: 3/2 grow/shrink: 4/2 up/down: 312/-432)         Total: -120 bytes
>    text	   data	    bss	    dec	    hex	filename
>  701175	   2097	   9064	 712336	  ade90	busybox_old
>  701054	   2097	   9072	 712223	  ade1f	busybox_unstripped

Applied with more modifications on top.
Please review:

http://git.busybox.net/busybox/commit/?id=fef9ee70727452954d2c5d28cc65e8b0fffcd6f1
http://git.busybox.net/busybox/patch/?id=fef9ee70727452954d2c5d28cc65e8b0fffcd6f1

Thanks!
-- 
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]