[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH 00/39] Windows port, base and archival/
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2010-04-27 7:33:52
Message-ID: 201004270933.52934.vda.linux () googlemail ! com
[Download RAW message or body]

On Saturday 17 April 2010 21:48, Nguyen Thai Ngoc Duy wrote:
> 2010/4/17 Denys Vlasenko <vda.linux@googlemail.com>:
> > I think a positive form, "depends on TARGET_PLATFORM_POSIX",
> > is better - you do not need to touch it for a gazillion of
> > other weird platforms it does not run on (if you ever add them).
> > Also, at this step, add it to every applet, not to applet groups.
> > The patch will be bigger, but further pathes will be smaller,
> > since they will only need to touch one entry whenever you make one
> > more applet to work on WIN - you add " || TARGET_PLATFORM_NATIVE_WIN"
> > for that applet.
> 
> How about general features that do not depend on any applets? There
> are some features that won't be supported on Windows, should it be
> "depends on !PLATFORM_MINGW32" or "depends on PLATFORM_POSIX" for
> them?

depends on PLATFORM_POSIX

-- 
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]