[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] modutils: Add /proc/cmdline module option parsing support
From:       walter harms <wharms () bfs ! de>
Date:       2010-02-28 12:48:46
Message-ID: 4B8A662E.2090207 () bfs ! de
[Download RAW message or body]



Denys Vlasenko schrieb:
> On Saturday 23 January 2010 00:50, Ozan Çağlayan wrote:
>> This adds module option parsing support from /proc/cmdline like in
>> module-init-tools.
>>
>> The options passed through /proc/cmdline are always squeezed by the ones
>> provided with command line arguments.
> 
> Applied a slightly different version based on your code:
> 
> http://git.busybox.net/busybox/commit/?id=3e26d4fa233705f2061b6f296ac2a604e94f508a
> 
> Thanks!

There is now a fixed buffer 2048. IMHO that may cause trouble if it changes for whatever reason.
perhaps it is more clever to use xmalloc_open_read_close() ? Just in case ?

re,
 wh
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

[prev in list] [next in list] [prev in thread] [next in thread]