[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] Fix tftp put protocol violation
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2009-07-24 20:35:43
Message-ID: 200907242235.43883.vda.linux () googlemail ! com
[Download RAW message or body]

On Friday 24 July 2009 18:06, Atsushi Nemoto wrote:
> Current tftp/tftpd implementation violates RFC2347 ("TFTP Option
> Extension") on write request.  The first DATA packet should have block
> number 1 but tftp send DATA packet with block number 0 and tftpd
> expects this wrong behavior.
> 
> >From RFC2347:
>       client                                           server
>       -------------------------------------------------------
>       |2|barfile|0|octet|0|blksize|0|2048|0|  -->               WRQ
>                                     <--  |6|blksize|0|2048|0|   OACK
>       |3|1| 2048 octets of data |  -->                          DATA
>                                                    <--  |4|1|   ACK
> 
> Current behavior:
>       client                                           server
>       -------------------------------------------------------
>       |2|barfile|0|octet|0|blksize|0|2048|0|  -->               WRQ
>                                     <--  |6|blksize|0|2048|0|   OACK
>       |3|0| 2048 octets of data |  -->                          DATA
>                                                    <--  |4|0|   ACK

Applied, thanks!
--
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic