[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    regarding busybox 1.13.4  -  tar_with_link_with_size test  failure
From:       "Maxin John" <maxinbjohn () rediffmail ! com>
Date:       2009-05-28 9:11:58
Message-ID: 20090528091158.37756.qmail () f4mail-234-237 ! rediffmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi,

During busybox 1.13.4 testing, I have observed that the \
"testsuite/tar/tar_with_link_with_size" test fails. Test Result: "FAIL: \
tar_with_link_with_size"

I have analyzed this failure and found that this is due to the mismatch between \
expected and the actual output: expected output:
"
res1="\
lrwxrwxrwx user/group 0 2008-07-19 15:02:37 \
                firmware-372/sources/native/bin/chroot-setup.sh -> qemu-setup.sh
-rwxr-xr-x user/group 512 2008-07-19 15:02:37 \
firmware-372/sources/native/bin/qemu-setup.sh" "

actual output(currently running as root):
"
res1="\
lrwxrwxrwx 0/0         0 2008-07-19 15:02:37 \
                firmware-372/sources/native/bin/chroot-setup.sh -> qemu-setup.sh
-rwxr-xr-x 0/0       512 2008-07-19 15:02:37 \
firmware-372/sources/native/bin/qemu-setup.sh" "

Based on this observation, I have generalized the expected output and created a patch \
for this test case. After applying the below listed patch, this test passes. Test \
Result: "PASS: tar_with_link_with_size"

Please let me know your opinion on this patch.

----------------------------
--- /tmp/tar/tar_with_link_with_size    2008-11-09 17:28:19.000000000 +0000
+++ tar/tar_with_link_with_size 2009-05-28 08:03:30.000000000 +0000
@@ -19,9 +19,11 @@
     $ECHO -ne "\x90\xc3\x82\x29\xe8\x8c\xb8\x95\x83\x32\x40\x61\x11\x11\xd3\xaa"
     $ECHO -ne "\x3f\x8b\xb9\x22\x9c\x28\x48\x0a\x22\x71\xee\x80"
 }

+user=`id -u`
+group=`id -g`
 res1="\
-lrwxrwxrwx user/group         0 2008-07-19 15:02:37 \
                firmware-372/sources/native/bin/chroot-setup.sh -> qemu-setup.sh
--rwxr-xr-x user/group       512 2008-07-19 15:02:37 \
firmware-372/sources/native/bin/qemu-setup.sh" +lrwxrwxrwx $user/$group         0 \
2008-07-19 15:02:37 firmware-372/sources/native/bin/chroot-setup.sh -> qemu-setup.sh \
+-rwxr-xr-x $user/$group       512 2008-07-19 15:02:37 \
firmware-372/sources/native/bin/qemu-setup.sh"  export TZ=UTC-2


[Attachment #5 (unknown)]

Hi,<br />
<br />
During busybox 1.13.4 testing, I have observed that the \
"testsuite/tar/tar_with_link_with_size" test fails.<br /> Test Result: "FAIL: \
tar_with_link_with_size"<br /> <br />
I have analyzed this failure and found that this is due to the mismatch between \
expected and the actual output:<br /> expected output:<br />
"<br />
res1="<br />
lrwxrwxrwx user/group 0 2008-07-19 15:02:37 \
                firmware-372/sources/native/bin/chroot-setup.sh -> qemu-setup.sh<br \
                />
-rwxr-xr-x user/group 512 2008-07-19 15:02:37 \
firmware-372/sources/native/bin/qemu-setup.sh"<br /> "<br />
<br />
actual output(currently running as root):<br />
"<br />
res1="<br />
lrwxrwxrwx 0/0         0 2008-07-19 15:02:37 \
                firmware-372/sources/native/bin/chroot-setup.sh -> qemu-setup.sh<br \
                />
-rwxr-xr-x 0/0       512 2008-07-19 15:02:37 \
firmware-372/sources/native/bin/qemu-setup.sh"<br /> "<br />
<br />
Based on this observation, I have generalized the expected output and created a patch \
for this test case. After applying the below listed patch, this test passes.<br /> \
Test Result: "PASS: tar_with_link_with_size"<br /> <br />
Please let me know your opinion on this patch.<br />
<br />
----------------------------<br />
--- /tmp/tar/tar_with_link_with_size    2008-11-09 17:28:19.000000000 +0000<br />
+++ tar/tar_with_link_with_size 2009-05-28 08:03:30.000000000 +0000<br />
@@ -19,9 +19,11 @@<br />
     $ECHO -ne "x90xc3x82x29xe8x8cxb8x95x83x32x40x61x11x11xd3xaa"<br />
     $ECHO -ne "x3fx8bxb9x22x9cx28x48x0ax22x71xeex80"<br />
 }<br />
<br />
+user=`id -u`<br />
+group=`id -g`<br />
 res1="<br />
-lrwxrwxrwx user/group         0 2008-07-19 15:02:37 \
                firmware-372/sources/native/bin/chroot-setup.sh -> qemu-setup.sh<br \
                />
--rwxr-xr-x user/group       512 2008-07-19 15:02:37 \
firmware-372/sources/native/bin/qemu-setup.sh"<br /> +lrwxrwxrwx $user/$group         \
0 2008-07-19 15:02:37 firmware-372/sources/native/bin/chroot-setup.sh -> \
qemu-setup.sh<br /> +-rwxr-xr-x $user/$group       512 2008-07-19 15:02:37 \
firmware-372/sources/native/bin/qemu-setup.sh"<br />  export TZ=UTC-2<br><Table \
border=0 Width=644 Height=57 cellspacing=0 cellpadding=0 \
style="font-family:Verdana;font-size:11px;line-height:15px;"><TR><td><A \
HREF="http://sigads.rediff.com/RealMedia/ads/click_nx.ads/www.rediffmail.com/signatureline.htm@Middle?" \
target="_blank"><IMG \
SRC="http://sigads.rediff.com/RealMedia/ads/adstream_nx.ads/www.rediffmail.com/signatureline.htm@Middle"></A></td></TR></Table>




_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

[prev in list] [next in list] [prev in thread] [next in thread]