[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] Add flash_lock and flash_unlock applets.
From:       Thierry Reding <thierry.reding () avionic-design ! de>
Date:       2009-05-22 9:13:52
Message-ID: 20090522091352.GA14923 () avionic-design ! de
[Download RAW message or body]

* Thierry Reding wrote:
> * Tito wrote:
> [...]
> > Hi,
> > please use libbb functions as shown above.
> > It seems to me that due to the fact that the applets share
> > a lot of code they could be merged into one applet and at runtime
> > you can check:
> > 
> > 	if (applet_name[6] == 'u') {
> > 		/* do flash unlock stuff */
> > 	}else {
> > 		/* do flash lock stuff */
> > 	}
> 
> Wouldn't that break bb_show_usage()? Can I alternatively put both of the
> applets' main functions into one source file and factor out shared code?

Nevermind. I've reposted a patch that combines both flash_lock and
flash_unlock in a single applet.

Thierry
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]