[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: fbsplash - segfault
From:       Bernhard Reutner-Fischer <rep.dot.nop () gmail ! com>
Date:       2009-02-25 18:28:02
Message-ID: 20090225182802.GC15548 () mx ! loc
[Download RAW message or body]

On Mon, Feb 23, 2009 at 06:28:23PM +0100, Michele Sanges wrote:
> About the fbsplash applet, the log message of the revision 25366 says:
>
>>  bail out if screen resolution does not match PPM dimensions.
>>   Previously a 640x480 PPM on an e.g. 720x400 console would just segfault when
>>   reading the lines. While this bug should perhaps be fixed to handle such cases
>>   properly we just exit gracefully until somebody is willing to take care of it
>>   properly.
>
>
> fbsplash supports only display with 16bpp colour depth. Unfortunately I
> can't change the framebuffer of my laptop display to another resolution
> maintaining the same colors number.
>
> I tried to display on my 640x480, 16bpp framebuffer, two images; the
> first one smaller and the second one larger than my screen resolution.
> In both cases the images are displayed correctly, without any
> segmentation fault.
>
> Are you sure that the problem is the image resolution and not its colors
> number? Both my images are in RGB colors (24 bpp), as required by the
> fbsplash; their are converted to 16bpp (565 coded) within the
> fb_drawimage function:

Oh, that could be. Should we be able to substract all header stuff from st_size
and calculate if we need to convert to 16bpp?
>
> Can you send me the image are you using?

http://busybox.net/~aldot/bb/blueeye_white.ppm
87b86fc1901520dd017a748a2fa7e81f  blueeye_white.ppm
about 900k big.
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]