[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [patch v2] Add flash_eraseall from mtd-utils
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2009-02-24 16:47:17
Message-ID: 200902241747.17987.vda.linux () googlemail ! com
[Download RAW message or body]

On Sunday 22 February 2009 08:55:45 am Alex Landau wrote:
> ----- Original Message ----
> 
> > From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
> > To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > Cc: busybox@busybox.net
> > Sent: Wednesday, February 18, 2009 3:29:50 PM
> > Subject: Re: [patch v2] Add flash_eraseall from mtd-utils
> > 
> > On Tue, Feb 17, 2009 at 11:03:28PM +0100, Sebastian Andrzej Siewior wrote:
> > >This is the result after converting mtd-utils' flash_eraseall to BB.
> > 
> > Applied as r25355 and shrank by ca. 110 bytes in r25356, thanks.
> > _______________________________________________
> > busybox mailing list
> > busybox@busybox.net
> > http://lists.busybox.net/mailman/listinfo/busybox
> 
> Hi,
> 
> Not compiled or tested it, but from reading the code it seems that r25356
> broke one thing. On line 145 (looking at r25376) it's written flags = ~BBTEST, while
> as far as I can tell, the original version r25355 intended  flags &= ~BBTEST.
> The regression breaks erasing NOR flashes.

Fixed in svn. Sorry...
--
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]