[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [patch] tar -c messing file/device mode
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2009-01-20 2:53:27
Message-ID: 200901200353.27747.vda.linux () googlemail ! com
[Download RAW message or body]

On Friday 16 January 2009 10:01, Timo Teräs wrote:
> Hi,
> 
> I had on some systems very mysterious changes of /dev/null mode to 
> "crw-r--r--" that will cause all kind of bad things to happen.
> 
> After some tedious debugging, I was able to isolate it to one
> script that did:
>   tar -c -v -I includelist -X excludelist somefiles > /dev/null
> 
> to get a hold of file names that would be included in the archive.
> But this single command managed to mess the /dev/null mode.
> 
> It appears that tar.c uses fchmod to change the file permissions
> when creating the archive. But that's the completely wrong thing
> to do for directions when outputting to stdout. And in any case
> you should be relying on umask and not some fixed mode.

GNU tar does not do this, so yes, you are 100% right.

Applied, thanks!
--
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

[prev in list] [next in list] [prev in thread] [next in thread]