[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: changes in halt.c
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2008-10-31 23:53:27
Message-ID: 200811010053.27080.vda.linux () googlemail ! com
[Download RAW message or body]

On Friday 31 October 2008 22:51, Denys Vlasenko wrote:
> On Friday 31 October 2008 19:19, Jon Nalley wrote:
> > All,
> > 
> > After upgrading to 1.12.1 I noticed that the 'reboot' command no
> > longer worked for me (nothing happened when running reboot).  I should
> > note that I am *not* using 'init' from busybox.  I looked at the diff
> > of halt.c between 1.11.3 and 1.12.1 and noticed the following change
> > that breaks in my use case:
> > 
> > -        if (ENABLE_INIT && !(flags & 4)) {
> > +        rc = 1;
> > +        if (!(flags & 4)) { /* no -f */
> > 
> > Note that since the check for "ENABLE_INIT" has been removed the code
> > seems to always assume that init is busybox's init.
> > 
> > After adding "ENABLE_INIT" back into the if() things work as expected.
> 
> You mean, no your reboot (without -f)

s/no/now/

> just instantaneously reboots your machine.
> 
> Don't you think that may be a very unpleasant surprise for some users?
> --
> vda
> 
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]