[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: util-linux/mdev.c:49: warning: 'aliaslink
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2008-05-24 20:56:29
Message-ID: 200805242256.29371.vda.linux () googlemail ! com
[Download RAW message or body]

On Thursday 22 May 2008 23:53, Cristian Ionescu-Idbohrn wrote:
> On Thu, 22 May 2008, Denys Vlasenko wrote:
> 
> > Fixed, thanks. Canonical way is to do int aliaslink = aliaslink; -
> > this avoids emitting useless code.
> 
> I'll try to remember that.
> I noticed some small whitespace damage came in with latest update.
> 
> Index: util-linux/mdev.c
> ===================================================================
> --- util-linux/mdev.c	(revision 22058)
> +++ util-linux/mdev.c	(working copy)
> @@ -273,7 +273,7 @@
> 
>  				/* move the device, and optionally
>  				 * make a symlink to moved device node */
> -				if (rename(device_name, alias) == 0 && aliaslink == '>')
> +				if (rename(device_name, alias) == 0 && aliaslink == '>')
>  					symlink(alias, device_name);
> 
>  				free(alias);

Applied, thanks
--
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic