[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: testing a single applet;
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2008-04-30 0:01:45
Message-ID: 200804300201.45135.vda.linux () googlemail ! com
[Download RAW message or body]

On Tuesday 29 April 2008 18:18, Bernhard Fischer wrote:
> >+			"CVS")
> >+				continue
> >+				;;
> >+			.*)
> >+				continue
> >+				;;
> > 		esac
> 
> perhaps it's simpler (and maybe even a tad faster) to say
> 
> case "${testcase##*/}" in
> \#*|*\~|"CVS"|.*) continue ;;
> esac

To be honest, I applied these patches to make Christian happy.
That's the main reason. I don't see them as essential improvements.
I hope these semi-useless discussions "how to make runtest
the prettiest shell script ever" will not last forever. :(

> >-#		echo "Running test ${tsdir:-.}/$applet.tests"
> >-		PATH="$LINKSDIR:$tsdir:$bindir:$PATH" "${tsdir:-.}/$applet.tests"
> >+#		echo "Running test $tsdir/$applet.tests"
> >+		PATH="$LINKSDIR:$tsdir:$bindir:$PATH" "$tsdir/$applet.tests"
> > 		test $? -eq 0 || status=1

Well, this is a no-op (because code above assumes that $tsdir is not
empty, and will break otherwise.

> I think that it was possible to invoke one test-series for exactly one
> applet by doing:
> $ ./runtest test.tests

$ ./runtest test     [without ".tests"]

It is still possible.

> PS: reading test.tests, perhaps it would make sense to allow for
> "command" to prevent using builtins? Just curious..

Didn't understand you here...
--
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]