[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] ping: fix ping request information leak
From:       Peter Korsgaard <jacmet () uclibc ! org>
Date:       2008-04-29 12:39:16
Message-ID: 87y76w96ob.fsf () macbook ! be ! 48ers ! dk
[Download RAW message or body]

>>>>> "Denys" == Denys Vlasenko <vda.linux@googlemail.com> writes:

Hi,

 Denys> Hmm, and where's sendping6? Ah, you probably dont have IPv6 on...

Exactly.

 >> 
 >> +	memset(pkt, 0, datalen + ICMP_MINLEN + 4);
 pkt-> icmp_type = ICMP_ECHO;
 pkt-> icmp_code = 0;
 pkt-> icmp_cksum = 0;

 Denys> and these assignments of zeros may die now.

True.

 Denys> Applied, thanks.

You're welcome.

-- 
Bye, Peter Korsgaard
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]