[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [patch] testsuite/runtest: cleanup
From:       "Lombard, David N" <dnlombar () ichips ! intel ! com>
Date:       2008-04-28 14:42:11
Message-ID: 20080428144211.GA30655 () nlxdcldnl2 ! cl ! intel ! com
[Download RAW message or body]

On Sun, Apr 27, 2008 at 10:58:58AM +0200, Cristian Ionescu-Idbohrn wrote:
> I'll comment the patch here, but see attached for a clean version.
> This has more academic than practical importance ;-)
> 
> * neither $lcwd nor ${lcwd%/*} need to be quote protected
...
> * "links" does not need to be quote protected
> * the general style in the script is _not_ to write simple if-blocks
>   on a single line
...
> * a one liner would look like this:
...
> * applet does not need to be protected

Ah, comprehension of rules and appreciation style.

-- 
David N. Lombard, Intel, Irvine, CA
I do not speak for Intel Corporation; all comments are strictly my own.
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]