[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: Dhcp client
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2008-04-23 16:08:52
Message-ID: 200804231808.52314.vda.linux () googlemail ! com
[Download RAW message or body]

On Wednesday 23 April 2008 17:53, walter harms wrote:
> mmh,
> i can not try it here but alpha would be a candidate
> ntohl will be reduced to nothing and the could result in a
> unaligned access. how does arm handle it ?
> 
> Nico Erfurth wrote:
> > Hi,
> > 
> > I'm currently working a bit on udhcpc, I've fixed some timeout issues 
> > and added the G-Trick so far. But while browsing the source a bit i 
> > found that (around line 550):
> > 
> > /* can be misaligned, thus memcpy */
> > memcpy(&lease_seconds, temp, 4);
> > lease_seconds = ntohl(lease_seconds);
> > 
> > Is there any architecture that needs the input of ntohl to be aligned?

Definitely. That comment was added exactly because it was seen
trapping on misaligned accesses there.
--
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]