[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [patch] udhcpc RFC-compliance
From:       Denis Vlasenko <vda.linux () googlemail ! com>
Date:       2008-01-25 19:27:31
Message-ID: 200801251927.31493.vda.linux () googlemail ! com
[Download RAW message or body]

On Friday 25 January 2008 09:59, Jonas Danielsson wrote:
> Jonas Danielsson wrote:
> > Hello,
> >
> > The udhcp client currently does not follow RFC2131
> > (http://www.ietf.org/rfc/rfc2131.txt) when sending DHCPDECLINE and 
> > DHCPRELEASE
> > messages.
> >
> > The send_decline function in clientpacket.c includes the Parameter 
> > request
> > list in the packet, something the RFC tells us that we MUST NOT do.
> > Also send_decline neglects to include the Requested ip address and the
> > Server identifier.
> >
> > The function init_packet, also in clientpacket.c, always includes the
> > Vendor class identifier even tho the RFC tells us that we MUST NOT 
> > include
> > it in DHCPDECLINE or DHCPRELEASE messages. And send_release currently 
> > includes
> > the Requested IP address something we MUST NOT do.
> >
> > The attached patch fixes this. It's against the daily snapshop of 
> > 20080118.
> >
> > Regards
> > Jonas Danielsson
> Is there no interest for this patch?

Applied, thanks!
--
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]