[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: Remove common patterns
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2007-09-30 16:20:42
Message-ID: 200709301720.42577.vda.linux () googlemail ! com
[Download RAW message or body]

On Sunday 30 September 2007 15:28, Loïc Grenié wrote:
>      I've tried to remove "common patterns" in the code.
>   First try: s/printf("%s", /puts(/ and s/fprintf(fp, "%s",
> \(.*\))/fputs(\1, fp)/
>   Patch attached.

-               printf("%s", error_message(ctx->errcode));
+               puts(error_message(ctx->errcode));


These are not equivalent. puts is adding "\n".

Apart from this - applied, thanks.
--
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox

[prev in list] [next in list] [prev in thread] [next in thread]