[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: Fwd: [PATCH] chpasswd applet size reduction and bugfix
From:       Denis Vlasenko <vda.linux () googlemail ! com>
Date:       2007-07-21 22:23:16
Message-ID: 200707212323.16806.vda.linux () googlemail ! com
[Download RAW message or body]

On Saturday 21 July 2007 20:55, Alexander Shishkin wrote:
> On 7/21/07, Denis Vlasenko <vda.linux@googlemail.com> wrote:
> > > it fixes also a bug in commandline parsing:
> > > chpasswd must error out if -m and -e are set at the same time.
> >
> > Applied to svn (along with even more bugs fixed. It's scary how many
> > of them were there).
> >
> > Alex, care to eyescan/test what in svn now?
> Looks a whole lot better now (thanks a lot for your numerous fixes to this!).
> Except:
> - chpasswd.c:59 seems to have excessive indentation tab,

Fixed

> - may be it's time to move sizeof("$N$XXXXXXXX") to some header file,
> since it's used in both passwd.c and chpasswd.c (I'm not quite sure
> which header is better for such things if at all).

No gain in code size. Correctness is easer to check when you
don't need to grep .h files in order to find out what the size is.
--
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]