[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] Fix another httpd breakage on no-MMU
From:       Denis Vlasenko <vda.linux () googlemail ! com>
Date:       2007-06-23 23:14:02
Message-ID: 200706240114.02355.vda.linux () googlemail ! com
[Download RAW message or body]

On Thursday 21 June 2007 10:51, Alex Landau wrote:
> Hi,
> 
> Another round of fixes to httpd for no-MMU.
> httpd can't work in non-inetd mode since it is required to fork for each connection.
> There are 2 approaches I can think of:
> 1. The correct one: on connection, the parent vforks and the child reexecs itself to
> serve the connection.
> 2. The easy one: require -i (inetd mode) and #ifdef the code that prevents compilation on
> no-mmu (the code running bb_daemonize).
> 
> The attached patch goes the second way for 2 reasons. First, the second way is much
> easier, so we get a working httpd. Second, I'm not sure that it's benefiting to reexec
> httpd on every connection, since inetd does exactly that. And, of course, the most
> important reason: I'm lazy ;-)
> 
> Alex
> 
> P.S. On compilation a warning shows telling that openServer() is defined but not used.
> This function is used only in non-inetd mode. I did not wrap it in #if !BB_MMU since if
> later someone goes with way 1 (above), he'll need it, and since it's static, it does not
> reach the .o file.

Well, removing #if wouldn't be hard too ;) so I added #if/#endif block.

Applied to svn, thanks.
--
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]