[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [patch] test applet
From:       Denis Vlasenko <vda.linux () googlemail ! com>
Date:       2007-05-27 3:45:24
Message-ID: 200705270545.24121.vda.linux () googlemail ! com
[Download RAW message or body]

On Sunday 27 May 2007 05:03, Denis Vlasenko wrote:
> On Saturday 26 May 2007 15:24, Souf wrote:
> > I saw that my 1st patch was not applied, so better because I have
> > another, it correct the bug and remove getn(const char *s) function
> 
> --- busybox/coreutils/test.c.orig       2007-05-24 23:01:44.000000000 +0200
> +++ busybox/coreutils/test.c    2007-05-26 11:48:52.000000000 +0200
> @@ -150,8 +150,10 @@ enum { NUM_OPS = sizeof(ops) / sizeof(op
> 
>  #if ENABLE_FEATURE_TEST_64
>  typedef int64_t arith_t;
> +#define test_xatoi(x) xatoll(x)
>  #else
>  typedef int arith_t;
> +#define test_xatoi(x) xatol(x)
>  #endif
> 
> You introduced the following bug:
> 
> # ./busybox ash
> # test 632847655483264856238475 -le 3284573759234759824375987249
> ash: invalid number '632847655483264856238475'
> <ash exits>

Ok, it should be fixed in svn now, along with obscure memory leak
which was accidentally spotted.
--
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]