[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: PATCH: fix for broken run-parts
From:       "Gabriel L. Somlo" <somlo () cmu ! edu>
Date:       2007-04-30 15:45:43
Message-ID: 20070430154543.GB15142 () hedwig ! net ! cmu ! edu
[Download RAW message or body]

Ok, please disregard the last patch I sent :) I just realized that
bb_get_last_path_component() *must* be destructive, since if the
argument *ends* with a '/', we have to hack it off...

The only other way to do this would be for
bb_get_last_path_component() to return a newly allocated string, but
I'm not sure I like this any better.

So, nevermind replacing it with strrchr()

Sorry for all the noise :)

--Gabriel


> If so, here's another patch doing just that (should go on top of
> svn 18532 or later). While we're at it, I modified
> bb_get_last_path_component() to be non-destructive of its argument.
> If this patch is applied, we can proceed to remove all the "dirty
> hacks" used to work around bb_get_last_path_component() being
> destructive (lots of xstrdup() calls and the like :) )
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]