[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    dpkg - updating a package can break dependencies
From:       "Kim B. Heino" <Kim.Heino () bluegiga ! com>
Date:       2007-02-23 13:28:22
Message-ID: 45DEEBF6.8030907 () bluegiga ! com
[Download RAW message or body]

Hello,

When installing a new package with dpkg dependencies are checked 
correctly. But when I try to update an existing package, the 
dependencies are checked against the old package, not against new 
package. Thus the new package can break dependencies.

Attached patch fixes this problem. It should apply cleanly to todays 
snapshot.

["dpkg-collision.patch" (text/x-patch)]

--- busybox/archival/dpkg.c.orig	2007-02-23 10:20:07.000000000 +0200
+++ busybox/archival/dpkg.c	2007-02-23 15:17:59.000000000 +0200
@@ -643,11 +643,9 @@
 		return -1;
 	}
 	num = search_package_hashtable(new_node->name, new_node->version, VER_EQUAL);
-	if (package_hashtable[num] == NULL) {
-		package_hashtable[num] = new_node;
-	} else {
-		free_package(new_node);
-	}
+	if (package_hashtable[num] != NULL)
+		free_package(package_hashtable[num]);
+	package_hashtable[num] = new_node;
 	return num;
 }
 


_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox

[prev in list] [next in list] [prev in thread] [next in thread]