[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [RFC, PATCH] passwd size reduction
From:       Denis Vlasenko <vda.linux () googlemail ! com>
Date:       2006-11-30 23:24:12
Message-ID: 200612010024.12521.vda.linux () googlemail ! com
[Download RAW message or body]

On Thursday 30 November 2006 20:44, Bernhard Fischer wrote:
> >I applied the rest. Also started to look into passwd.c... well...
> >not very pretty.
> 
> it's ugly, yes. Tito rewrote it a while back, but the patch was not
> applied, IIRC. Not sure about the reasoning.
> 
> http://busybox.net/lists/busybox/2006-November/025406.html
> 
> I didn't have a chance to look at Tito's reimpl, but if it's smaller
> than what we have now (including the goto-ification), then by all
> means, apply it. It can't be worse than the current incarnation ;)

Spent today rewriting most of it. Entire backup function is eliminated,
large on-stack and bss buffers are history too.
--
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]