[prev in list] [next in list] [prev in thread] [next in thread]
List: busybox
Subject: Re: svn commit: trunk/busybox/modutils
From: "Yann E. MORIN" <yann.morin.1998 () anciens ! enib ! fr>
Date: 2006-11-22 20:17:44
Message-ID: 200611222117.44846.yann.morin.1998 () anciens ! enib ! fr
[Download RAW message or body]
Hello!
On Tuesday 21 November 2006 151, vda@busybox.net wrote:
> Author: vda
> Date: 2006-11-21 06:12:53 -0800 (Tue, 21 Nov 2006)
> New Revision: 16607
[--SNIP--]
> insmod: set STRVERSIONLEN = 64, convert #ifdef CONFIG to #if ENABLE,
> stop using CONFIG_ prefix for non-config-system variables
[--SNIP--]
> -enum { STRVERSIONLEN = 32 };
> +enum { STRVERSIONLEN = 64 };
That's wrong. As I commented in the bug report (issue #1007), the kernel sources
does max it out to (64 - sizeof(unsigned long)).
See include/linux/modules.h@32 in the kernel sources.
Now, we can have a bigger buffer, but I don't see why we would not stick to the
kernel value (except a +1 for the terminating '\0').
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software Designer | \ / CAMPAIGN | ^ |
| --==< °_° >==-- °------------.-------: X AGAINST | /e\ There is no |
| http://ymorin.is-a-geek.org/ | (*_*) | / \ HTML MAIL | """ conspiracy. |
°------------------------------°-------°------------------°--------------------°
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic