[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: svn 16201 - 16197
From:       Rob Landley <rob () landley ! net>
Date:       2006-09-24 23:49:22
Message-ID: 200609241949.22930.rob () landley ! net
[Download RAW message or body]

On Saturday 23 September 2006 10:11 pm, Denis Vlasenko wrote:
> On Saturday 23 September 2006 21:45, Tito wrote:
> > Hi Denis,
> > svn 16201:
> > vlock:
> > 
> > -                printf("Virtual Console%s locked.\n%s's ", 
(o_lock_all) ? "s" : "", pw->pw_name);
> > +                printf("Virtual Console%s locked. Enter %s's password to 
unlock\n", (o_lock_all) ? "s" : "", pw->pw_name);
> > 
> > correct_password:
> > 
> > unencrypted = bb_askpass ( 0, "Password: " );  
> > 
> > This is bloat and you get a double password prompt, please revert.
> > 
> > Virtual Console locked. Enter root's password to unlock
> > Password:
> > 
> > This looks uglier than before.....
> 
> Before it was as follows:
> 
> Virtual Console locked.
> root's Password:
> 
> ain't it Look wrong? 

no it Does not.

Bloating the code to take care of minor issues of capitalization is not a good 
thing.  Don't do it.

> The root of it is that correct_password() always uses "Password:"
...
> This isn't acceptable, I think.

It is perfectly acceptable to me.

Rob
-- 
Never bet against the cheap plastic solution.
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]