[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] Make start-stop-daemon handle sending signals better
From:       Natanael Copa <natanael.copa () gmail ! com>
Date:       2006-08-31 15:38:31
Message-ID: 1157038711.10578.107.camel () localhost
[Download RAW message or body]

On Wed, 2006-08-30 at 18:53 -0400, Rob Landley wrote:

> It sounds like the problem is we're being too clever.  ls -l /proc/self/exe
> says that "/proc/self/exe" is a symlink to "/bin/ls", and we really don't
> care if /bin/ls is a symlink to a shared executable.  The check for device
> and inode is what's screwing us up, because the heuristic is wrong and we
> should not do that.  If the same executable is called by two names, it may be
> performing two functions.  We are.  Call readlink once, use the result in a
> string comparison, and stop trying to be too clever for our own good.
> 
> Does this sound reasonable?  I'll happily apply a patch to simplify the code
> and be _less_ clever, if it fixes the problem.

Sounds good. I agree. Thank you very much for your suggestions. 

I'll make a new patch as soon I get a chance.

--
Natanael Copa

_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]