[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] aesthetics for interface.c, and proper printout for
From:       "Robert P. J. Day" <rpjday () mindspring ! com>
Date:       2006-06-26 21:50:43
Message-ID: Pine.LNX.4.64.0606261749430.3476 () localhost ! localdomain
[Download RAW message or body]

On Mon, 26 Jun 2006, Rob Landley wrote:

> On Monday 26 June 2006 8:01 am, Robert P. J. Day wrote:
> >   now that i have commit access (whoo hoo!  a round for the house,
> > barkeep, and put it on my tab), i figure i'll run potential patches
> > past the collective first.
> >
> >   this patch has already been presented in two parts.  it's mostly
> > aesthetic, but also cleans up the output format for the "sit0"
> > interface to be consistent with that from the most recent net-tools.
> >
> >   comments?  i realize we're in feature freeze, but this is a fairly
> > innocuous change and does fix the minor bug regarding sit0.  if it's
> > too late for this sort of thing, i'll just hold off until after the
> > official release.
>
> There's actually two things there, a cleanup and a new structure.

actually, my first preference would have been to submit it as two
separate commits based exactly on what you wrote.  i'll do it that
way, then.

> As much as I hate #ifdefs, shouldn't the new structure be #ifdef ipv6?

good point.

> The "bugfixes only part" is after tonight's snapshot.  I want people
> to be able to test tonight's snapshot and get a decent idea of what
> 1.2.0 will be like.  So if you can get it in today, go for it.

i should get it in within the hour, then.

rday
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]